Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tooltip-with-timeout example #954

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Conversation

saideepesh000
Copy link
Member

Adds tooltip with timeout example for #939

@vercel
Copy link

vercel bot commented Dec 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/EpkogK1dHnEssq3u1G1hr9B2AqxA
✅ Preview: https://ariakit-git-example-tooltip-with-timeout-ariakit.vercel.app

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/DvECRRxuw1VUruGPhQX73cCSP22Z
✅ Preview: Canceled

[Deployment for 48ab5b8 canceled]

@saideepesh000 saideepesh000 mentioned this pull request Dec 16, 2021
69 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #954 (48ab5b8) into v2 (3e53498) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #954      +/-   ##
==========================================
+ Coverage   41.77%   41.96%   +0.18%     
==========================================
  Files         151      152       +1     
  Lines        4081     4084       +3     
  Branches     1156     1156              
==========================================
+ Hits         1705     1714       +9     
+ Misses       2375     2369       -6     
  Partials        1        1              
Impacted Files Coverage Δ
...ooltip/__examples__/tooltip-with-timeout/index.tsx 100.00% <100.00%> (ø)
packages/ariakit/src/tooltip/tooltip-state.ts 97.91% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e53498...48ab5b8. Read the comment docs.

@saideepesh000 saideepesh000 marked this pull request as ready for review December 16, 2021 12:58
Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @saideepesh000! Just made a few suggestions.

@vercel vercel bot temporarily deployed to Preview – reakit December 16, 2021 18:05 Inactive
@saideepesh000 saideepesh000 changed the title Add tooltip-with-timeout example Chore: Add tooltip-with-timeout example Dec 16, 2021
Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @saideepesh000! 🚀

@diegohaz diegohaz changed the title Chore: Add tooltip-with-timeout example chore: Add tooltip-with-timeout example Dec 16, 2021
@diegohaz diegohaz merged commit 6eb6088 into v2 Dec 16, 2021
@diegohaz diegohaz deleted the example/tooltip-with-timeout branch December 16, 2021 20:47
@saideepesh000
Copy link
Member Author

Thank you @saideepesh000! 🚀

Thanks to you @diegohaz , happy to help ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants