Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tooltip-placement example #960

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

saideepesh000
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Dec 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/BCq9EjFnoDcbgg4iFKuond4CQ2ja
✅ Preview: https://ariakit-git-example-tooltip-with-placement-ariakit.vercel.app

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/8twmRb2nsc673qSCUCrHsQ2vMmVU
✅ Preview: Canceled

[Deployment for dd40562 canceled]

@saideepesh000 saideepesh000 marked this pull request as draft December 21, 2021 17:47
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

import "./style.css";

export default function Example() {
const tooltip = useTooltipState({ placement: "bottom-end" });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegohaz , let me know if I should add any other placement examples like top, right, etc.. or only one example is enough ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example is fine I guess. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #960 (dd40562) into v2 (51c1083) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #960      +/-   ##
==========================================
+ Coverage   42.33%   42.37%   +0.04%     
==========================================
  Files         154      155       +1     
  Lines        4110     4113       +3     
  Branches     1160     1160              
==========================================
+ Hits         1740     1743       +3     
  Misses       2369     2369              
  Partials        1        1              
Impacted Files Coverage Δ
...c/tooltip/__examples__/tooltip-placement/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c1083...dd40562. Read the comment docs.

@saideepesh000 saideepesh000 mentioned this pull request Dec 21, 2021
69 tasks
@diegohaz
Copy link
Member

I think we should rename it to just tooltip-placement to be less verbose. When we start adding readme.md documentation to examples, we can add more descriptive titles like Tooltip with custom placement or so (there are other examples with the with word that we'll want to change later if we agree on this).

@saideepesh000
Copy link
Member Author

I think we should rename it to just tooltip-placement to be less verbose. When we start adding readme.md documentation to examples, we can add more descriptive titles like Tooltip with custom placement or so (there are other examples with the with word that we'll want to change later if we agree on this).

yeah, this makes sense to me

@vercel vercel bot temporarily deployed to Preview – reakit December 21, 2021 18:28 Inactive
@saideepesh000 saideepesh000 marked this pull request as ready for review December 21, 2021 18:28
@saideepesh000 saideepesh000 changed the title chore: Add tooltip-with-placement example chore: Add tooltip-placement example Dec 21, 2021
Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! ❤️

@diegohaz diegohaz merged commit 1966140 into v2 Dec 22, 2021
@diegohaz diegohaz deleted the example/tooltip-with-placement branch December 22, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants