Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add menu-item-checkbox example #961

Merged
merged 11 commits into from
Dec 23, 2021
Merged

chore: Add menu-item-checkbox example #961

merged 11 commits into from
Dec 23, 2021

Conversation

leonardoelias
Copy link
Contributor

@leonardoelias leonardoelias commented Dec 22, 2021

Adds a "Menu item checkbox" example #939.

Screen

Screen Shot 2021-12-21 at 23 47 13

@vercel
Copy link

vercel bot commented Dec 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/BQByGKepG5GL93jpnWmsWNvGkraB
✅ Preview: Canceled

[Deployment for f9f65ff canceled]

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/HPCE5yurXEby8bz3A3e1G8EuhVQv
✅ Preview: https://ariakit-git-fork-leonardoelias-v2-ariakit.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #961 (f9f65ff) into v2 (f950771) will increase coverage by 12.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v2     #961       +/-   ##
===========================================
+ Coverage   42.15%   54.15%   +12.00%     
===========================================
  Files         155      156        +1     
  Lines        4109     4114        +5     
  Branches     1158     1159        +1     
===========================================
+ Hits         1732     2228      +496     
+ Misses       2376     1885      -491     
  Partials        1        1               
Impacted Files Coverage Δ
...src/menu/__examples__/menu-item-checkbox/index.tsx 100.00% <100.00%> (ø)
packages/ariakit/src/composite/composite.ts 91.11% <0.00%> (+0.74%) ⬆️
packages/ariakit/src/composite/composite-item.tsx 59.45% <0.00%> (+1.62%) ⬆️
packages/ariakit/src/composite/composite-state.ts 86.45% <0.00%> (+7.29%) ⬆️
packages/ariakit/src/menu/menu-item-radio.tsx 9.09% <0.00%> (+9.09%) ⬆️
packages/ariakit/src/dialog/dialog.tsx 66.87% <0.00%> (+12.50%) ⬆️
packages/ariakit/src/checkbox/checkbox.tsx 84.28% <0.00%> (+12.85%) ⬆️
packages/ariakit/src/menu/menu-bar.ts 22.22% <0.00%> (+22.22%) ⬆️
packages/ariakit/src/menu/menu-group-label.ts 28.57% <0.00%> (+28.57%) ⬆️
packages/ariakit/src/menu/menu-group.ts 33.33% <0.00%> (+33.33%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f950771...f9f65ff. Read the comment docs.

@leonardoelias leonardoelias changed the title V2 chore: Add menu item checkbox example Dec 22, 2021
@saideepesh000 saideepesh000 mentioned this pull request Dec 22, 2021
69 tasks
@saideepesh000 saideepesh000 changed the title chore: Add menu item checkbox example chore: Add menu-item-checkbox example Dec 22, 2021
@saideepesh000
Copy link
Member

hey @leonardoelias , can u also add a readme file for menu, something like this Button

Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@diegohaz diegohaz merged commit bd1ebe7 into ariakit:v2 Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants