chore: Add toolbar example
#970
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). ariakit – ./🔍 Inspect: https://vercel.com/ariakit/ariakit/3MKRjMnyBiBXkLDrSrx5YpW5dxn9 [Deployment for ccd0a51 failed] reakit – ./🔍 Inspect: https://vercel.com/ariakit/reakit/5MgQe1RVfgyn4HHk63yDyb6n9kTR [Deployment for ccd0a51 canceled] |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## v2 #970 +/- ##
===========================================
+ Coverage 42.37% 62.35% +19.97%
===========================================
Files 155 160 +5
Lines 4113 4133 +20
Branches 1160 1159 -1
===========================================
+ Hits 1743 2577 +834
+ Misses 2369 1555 -814
Partials 1 1
Continue to review full report at Codecov.
|
|
hey @diegohaz is this how you were thinking? |
| } | ||
|
|
||
| .button { | ||
| @apply |
There was a problem hiding this comment.
is there a way to extend the button?
There was a problem hiding this comment.
What do you mean by extending the button? If we have to override a lot of styles, it's okay not to import the base button example and add everything here.
| } | ||
|
|
||
| .button svg { | ||
| @apply sm:block hidden; |
There was a problem hiding this comment.
here i am removing the icon when the screen reaches the width of sm. This so as not to break the playground
There was a problem hiding this comment.
That makes sense. We can also allow horizontal scrolling on the playground preview in such cases.
| Underline | ||
| </ToolbarItem> | ||
| <ToolbarSeparator className="toolbar-separator" /> | ||
| {/* @ts-ignore */} |
There was a problem hiding this comment.
sorry about that, but i couldn't resolve it.
| const menu = useMenuState({ orientation: "horizontal" }); | ||
| return ( | ||
| <> | ||
| {/* @ts-ignore */} |
There was a problem hiding this comment.
sorry about that, but i couldn't resolve it.
There was a problem hiding this comment.
What's the error message? Just let the CI throw it so we can find a solution.
|
Let's work on a single example per PR. You can open another PR for the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Adds a "toolbar" example #939.
Toolbar
Toolbar with menu
e-2f496bddc296.png">