69 describe broker also accepts broker host name #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 24, 2019 17:39
…d-stdout # Conflicts: # tests/integration/test_topic_controller.py
…nd 'master' of https://github.com/real-digital/esque into 62-accept-and-output-standardized-stdin-and-stdout
…t-standardized-stdin-and-stdout
added 17 commits
October 10, 2019 11:06
…t-standardized-stdin-and-stdout # Conflicts: # esque/cli/commands.py # esque/cli/options.py # esque/resources/broker.py # tests/integration/commands/test_apply.py # tests/integration/commands/test_get.py # tests/integration/commands/test_ping.py
…also-accepts-broker-host-name # Conflicts: # esque/cli/commands.py
…d-stdin-and-stdout' into 69-describe-broker-also-accepts-broker-host-name # Conflicts: # esque/cli/commands.py
…t-name # Conflicts: # esque/cli/commands.py # esque/cli/helpers.py # esque/cli/output.py # esque/resources/broker.py # tests/conftest.py # tests/integration/commands/test_apply.py # tests/integration/commands/test_creation.py # tests/integration/commands/test_deletion.py # tests/integration/commands/test_describe.py # tests/integration/commands/test_edit.py # tests/integration/commands/test_get.py # tests/integration/commands/test_ping.py # tests/unit/test_output.py
…also-accepts-broker-host-name
hfjn
approved these changes
Nov 14, 2019
swenzel
reviewed
Nov 14, 2019
esque/cli/commands.py
Outdated
| @@ -417,8 +426,16 @@ def get_watermarks(state: State, topic_name: str, output_format: str): | |||
| @click.argument("broker-id", callback=fallback_to_stdin, autocompletion=list_brokers, required=False) | |||
| @output_format_option | |||
| @default_options | |||
| def describe_broker(state: State, broker_id: str, output_format: str): | |||
| broker = Broker.from_id(state.cluster, broker_id).describe() | |||
| def describe_broker(state, broker_id, output_format): | |||
There was a problem hiding this comment.
Maybe rename broker_id to broker and add a help text stating that it actually supports both broker id and host:port combination? Actually we could make the port optional and only fail if there is more than one broker for a given host.
swenzel
approved these changes
Nov 14, 2019
garrettthomaskth
deleted the
69-describe-broker-also-accepts-broker-host-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.