Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place edit #19

Merged
merged 3 commits into from Jul 4, 2019
Merged

In-place edit #19

merged 3 commits into from Jul 4, 2019

Conversation

hfjn
Copy link
Contributor

@hfjn hfjn commented Jul 3, 2019

Adds basic in-place edit functionality for topics.
Calling esque edit topic <topic_name> opens an editor window based on the user's pre-defined editor and then edit the same configs which can be set via apply.

Also comes with basic as_yaml() method which should enable to export topics lists for apply in the future.

@hfjn hfjn added the enhancement New feature or request label Jul 3, 2019
@hfjn hfjn added this to the 1.0.0 milestone Jul 3, 2019
@hfjn hfjn self-assigned this Jul 3, 2019
Copy link
Contributor

@MrTrustworthy MrTrustworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hfjn hfjn merged commit d39612e into master Jul 4, 2019
@swenzel swenzel deleted the yaml-all-the-things branch April 7, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants