Transfer command #30
Merged
Transfer command #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still todo:
|
hfjn
suggested changes
Jul 10, 2019
swenzel
reviewed
Jul 19, 2019
swenzel
approved these changes
Jul 19, 2019
hfjn
approved these changes
Jul 22, 2019
| number_consumed_messages = _consume_to_file(working_dir, topic, group_id, from_context, numbers, avro, last) | ||
|
|
||
| if number_consumed_messages == 0: | ||
| click.echo(click.style("Execution stopped, because no messages consumed.", fg="red")) |
There was a problem hiding this comment.
I would state the reason for stopping the execution. No consumption is the effect. This case is probably getting hit when the topic is empty or the starting offset was chosen to high, right?
There was a problem hiding this comment.
How would you do this? Maybe checking the high_watermarks for all topics as indicator for an empty topic? But with log retention it could also be empty with a high_watermark greater 0.
There was a problem hiding this comment.
I didn't mean in that much detail.
The user can still find out what exactly the problem was by him/herself. You could just name the possible reasons in the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.