73 validity checks for edit #83

b-boehne · 2019-10-09T11:44:56Z

comparison with improve-exception-handling to not see Kevins changes which i merged in my branch to use his error handling

will of course merge to master after approval

…andling

… 77-fix-edit-topic-function

…-edit

swenzel

I think for now this is good, but in future we might want to use a more powerful validator. Like https://github.com/23andMe/Yamale for example.

esque/resources/topic.py

b-boehne · 2019-10-10T13:05:07Z

I think for now this is good, but in future we might want to use a more powerful validator. Like https://github.com/23andMe/Yamale for example.

damn I reinvented the wheel again, this is perfect for our use case
are you sure we don't want to use yamale from the get-go? i'd be willing to do it

# Conflicts: # esque/cli/commands.py

This reverts commit 1c31bc0

Bibob7 and others added 27 commits September 24, 2019 16:24

Handle SocketDisconnectedError

7fa54a9

Handle error cases for topic creation and deletion

98901c2

Add TopicControllerWithErrorHandling

d3e07e3

fix edit and write test

7e5a017

for some reason didn't get committed

f045b5f

Use error_handler decorator

88f3309

Fix test for apply command

ba73b7a

Add ExceptionWithMessage and remove catched exceptions in command

9e8ced3

Add output for unknown errors.

a292b2e

Use verbose mode for apply command tests

79e9ae4

Fix tests

2e2310f

Use second wrapper for KafkaException decorator

3b09177

Merge remote-tracking branch 'origin/master' into improve-exception-h…

8cd7d0f

…andling

Use sys.exit(0) by default in wrapper

56c285c

Fix method name

20f1c08

Use Confluent KafkaException in TopicController

6f72f2d

Use confluent KafkaException in TopicControllerTest

7538378

77: add all allowed configs dict and verify on every creation of a topic

091e286

ErrorHandler is only responsible to to output error messages

5c3be81

Use our KafkaException in tests

b6496af

Merge remote-tracking branch 'origin/improve-exception-handling' into…

42671aa

… 77-fix-edit-topic-function

77: use new exception classes

f1e0aa7

77: add tests for new functionality

3547b0c

Merge branch 'improve-exception-handling' into 73-validity-checks-for…

1916f92

…-edit

#73 formatting changes

cbedf9d

#73 - use isinstance instead of type() and add message to exception

e192047

#73 - use verbose to catch errors in tests

ebe6019

b-boehne force-pushed the 73-validity-checks-for-edit branch from d937593 to ebe6019 Compare October 10, 2019 08:29

swenzel suggested changes Oct 10, 2019

View reviewed changes

esque/resources/topic.py Outdated Show resolved Hide resolved

Swen Wenzel added 19 commits November 4, 2019 15:19

flush file before checking

6087d27

add schema glob to include section of tool.poetry in pyproject.toml

0c2c3c8

move validation to own function

f7c4cef

Merge branch 'master' into 73-validity-checks-for-edit

448afc9

# Conflicts: # esque/cli/commands.py

rename schema topic.yml to topic.yaml

039a898

run poetry update

1c31bc0

update build system requirement

45fc31e

disable installing editable esque

4d79961

Revert "run poetry update"

38f294e

This reverts commit 1c31bc0

run black

35d8f27

fix wrong class name in validators.py

78330d7

create helper for editing yaml data

8f8059a

change validation logic and create extra validator for edit topic

66b5431

change update_from_yaml to update_from_dict

a78816f

use refactored and new functions in edit_topic

f9abb6c

rename topic_editable.yaml to editable_topic.yaml

db2e7d5

refactor tests for edit topic

55d3056

fix validation for topic config

7e76ba8

add tests for new validation functions

ca0cfc0

swenzel force-pushed the 73-validity-checks-for-edit branch from 44297e2 to ca0cfc0 Compare November 5, 2019 12:48

fix black and flake8 issues

174a134

swenzel approved these changes Nov 5, 2019

View reviewed changes

swenzel requested a review from hfjn November 5, 2019 13:11

remove empty setup.py

219fec9

hfjn approved these changes Nov 5, 2019

View reviewed changes

Swen Wenzel added 2 commits November 5, 2019 14:24

minor refactoring

874158a

handle empty diff

c7bfbcb

swenzel force-pushed the 73-validity-checks-for-edit branch from 0e3e3d1 to c7bfbcb Compare November 5, 2019 13:50

swenzel merged commit b543992 into master Nov 5, 2019

swenzel deleted the 73-validity-checks-for-edit branch November 5, 2019 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

73 validity checks for edit #83

73 validity checks for edit #83

b-boehne commented Oct 9, 2019 •

edited

swenzel left a comment

b-boehne commented Oct 10, 2019

73 validity checks for edit #83

73 validity checks for edit #83

Conversation

b-boehne commented Oct 9, 2019 • edited

swenzel left a comment

Choose a reason for hiding this comment

b-boehne commented Oct 10, 2019

b-boehne commented Oct 9, 2019 •

edited