Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

65 improve config #96

Merged
merged 46 commits into from Nov 12, 2019
Merged

65 improve config #96

merged 46 commits into from Nov 12, 2019

Conversation

swenzel
Copy link
Contributor

@swenzel swenzel commented Nov 6, 2019

closes #65

Swen Wenzel and others added 30 commits November 4, 2019 14:59
change config tests so they run on all config versions
abf35cd
create migration script
e0b8fe8
migrate sample config
a608c93
create schema for new config file
ba7bd9d
Merge branch 'master' into 65-improve-config
a07670a 
# Conflicts:
#	poetry.lock
#	pyproject.toml
#	tests/conftest.py
update pyproject.toml to include the correct sample config
5d02414
move config schema to validation module
d5be4dd
rename and use validator for config
42a93e6
create command for config migration
80d72f2
introduce new ValidationException and refactor validation
ae46d0c
add validation and backup test for config
254e303
create config version exceptions
4ddf242
rename default config key for num_paritions
14524fd
update Config to support new yaml schema
7ad78d5
fix bugs in migration
8a0226f
update config tests and fix more bugs
6868f71
rename test configs and create one config for integration tests
eb4b7e5
add tests for default values and rename default_partitions to default…
1f08c09 
…_num_partitions
refactor tests
3af5ec8
lazy load config on cli state
24154ab
make it easier to patch config_path
e5443cb
also mock config_dir when mocking config_path
df51c48
@swenzel
Merge branch 'master' into 65-improve-config
88b0771
fix imports and formatting
3f6862e
fix test_edit_topic_calls_validator to check for other calls, too
2b889d3
Merge remote-tracking branch 'origin/65-improve-config' into 65-impro…
7c06773 
…ve-config
reformat, again
3fa659e
fix bug in test_edit_topic_calls_validator
1b699af
...
af1e966
move config commands
b6f282a
@swenzel swenzel requested a review from hfjn November 7, 2019 09:46
hfjn
hfjn approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@hfjn hfjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some two small comments. :)

esque/cli/commands.py Outdated Show resolved Hide resolved
esque/config/__init__.py Outdated Show resolved Hide resolved
esque/config/__init__.py Outdated Show resolved Hide resolved
@hfjn hfjn added this to the 1.0.0 milestone Nov 11, 2019
@hfjn hfjn added the enhancement New feature or request label Nov 11, 2019
@swenzel swenzel merged commit 122a2e9 into master Nov 12, 2019
@swenzel swenzel deleted the 65-improve-config branch November 12, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettthomaskth garrettthomaskth garrettthomaskth left review comments

@hfjn hfjn hfjn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Improve config
3 participants
@swenzel @hfjn @garrettthomaskth