Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jinyoungchoi95-issue67] Comment 추가/조회/삭제 기능 구현 #68

Merged
merged 17 commits into from Oct 29, 2021

Conversation

jinyoungchoi95
Copy link
Member

Issue: #67

작업 내용

  • POST /api/articles/{slug}/comments
  • GET /api/articles/{slug}/comments
  • DELETE /api/articles/{slug}/comments/{id}

생성/변경 로직

  • comment's 도메인 구성
  • comment 추가/삭제 관련 메소드 구현

@codecov-commenter
Copy link

Codecov Report

Merging #68 (9cf244b) into jinyoungchoi95 (2919434) will decrease coverage by 0.45%.
The diff coverage is 87.73%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             jinyoungchoi95      #68      +/-   ##
====================================================
- Coverage             91.75%   91.29%   -0.46%     
- Complexity              318      353      +35     
====================================================
  Files                    51       58       +7     
  Lines                   825      931     +106     
  Branches                 29       33       +4     
====================================================
+ Hits                    757      850      +93     
- Misses                   30       37       +7     
- Partials                 38       44       +6     
Impacted Files Coverage Δ
...tudy/realworld/article/comment/domain/Comment.java 73.07% <73.07%> (ø)
.../realworld/article/comment/domain/CommentBody.java 76.47% <76.47%> (ø)
...e/comment/controller/response/CommentResponse.java 90.47% <90.47%> (ø)
.../article/comment/controller/CommentController.java 100.00% <100.00%> (ø)
...mment/controller/request/CommentCreateRequest.java 100.00% <100.00%> (ø)
.../comment/controller/response/CommentsResponse.java 100.00% <100.00%> (ø)
...lworld/article/comment/service/CommentService.java 100.00% <100.00%> (ø)
...om/study/realworld/global/exception/ErrorCode.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2919434...9cf244b. Read the comment docs.

@jinyoungchoi95 jinyoungchoi95 merged commit 580adce into jinyoungchoi95 Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ori 오리의 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants