Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elb-certificate-arn() #98

Closed
wants to merge 1 commit into from

Conversation

jonhiggs
Copy link
Contributor

@jonhiggs jonhiggs commented Sep 2, 2016

No description provided.

@mbailey
Copy link
Contributor

mbailey commented Sep 16, 2016

Curious why this function includes awscli call instead of calling elbs()
This pattern is used throughout instance-functions

I actually don't mind repetition as it makes the function self contained. I would ideally want the project to use one or the other though.

@jonhiggs
Copy link
Contributor Author

You're right. Let me fix it.

The reason to fold it back was because I planned to implement an output parse. Probably column for text and something else for json.

@mbailey mbailey closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants