Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does stackup transform YAML templates into JSON before uploading? #74

Closed
mbailey opened this issue Aug 27, 2019 · 2 comments
Closed

Comments

@mbailey
Copy link

mbailey commented Aug 27, 2019

I've been informed that stackup transforms your YAML templates into JSON before uploading to CloudFormation.

Is this true?

This feels like suprising and unnecessary behaviour?

What's the purpose? Does StackUp depend on this for any functionality?

@tigris
Copy link
Contributor

tigris commented Aug 28, 2019

stackup transforms your YAML templates into JSON before uploading to CloudFormation. Is this true?

Yes. As per https://github.com/realestate-com-au/stackup/blob/dd0775994baa5c11e103209aa5cff5554997ec23/README.md#yaml-support

This feels like suprising and unnecessary behaviour?

Please see previous discussion: #31

What's the purpose?

I believe the original purpose was that AWS didn't support YAML at all, stackup did support YAML, so the only course of action was to translate it.

Does StackUp depend on this for any functionality?

Yes and no. See above about previous discussion. It'd require a lot of changes to the structure of the code, the feature set of stackup would change slightly.

I'll close this for now as it seems like you were just after more info for now? If we want to discuss further, we can open a feature request describing expected behaviour and test cases.

@ps-jay
Copy link
Contributor

ps-jay commented Apr 21, 2020

I've been informed that stackup transforms your YAML templates into JSON before uploading to CloudFormation.

Is this true?

Not strictly any more.
Implemented as --preserve-template-formatting in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants