Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Review EventData classes for conformity #28

Open
SimonDarksideJ opened this issue Apr 7, 2022 · 0 comments
Open

Feature Request: Review EventData classes for conformity #28

SimonDarksideJ opened this issue Apr 7, 2022 · 0 comments
Assignees
Labels
feature request New feature request

Comments

@SimonDarksideJ
Copy link
Contributor

Reality Collective - Reality Toolkit Feature Request

Is your feature request related to a problem? Please describe

After implementing the Controller Pose property to make accessing the current "Pose" of the controller, I found there there seems to be a lot of disparity in the properties exposed in our events:

  • InputEventData exposes Handedness but not controller (but can be found by querying the inputsource )
  • SourceStateEventData exposes controller but not handedness

Likely there are more cases.

How would you classify your suggestion

  • Architecture / Services

Describe the solution you'd like

Ideally, there should be more conformity between all the different event types and these should have a more uniform way to access things like:

  • InputSource
  • Controller
  • Controller Properties
  • Etc

Describe alternatives you've considered

Current solution is not ideal and only adds confusion when accessing events and event data

Additional context

Note this will likely be a breaking change.

@SimonDarksideJ SimonDarksideJ added the feature request New feature request label Apr 7, 2022
@SimonDarksideJ SimonDarksideJ self-assigned this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant