Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nesting: customize maximum value #1318

Closed
BalestraPatrick opened this issue Feb 17, 2017 · 3 comments
Closed

nesting: customize maximum value #1318

BalestraPatrick opened this issue Feb 17, 2017 · 3 comments
Labels
enhancement

Comments

@BalestraPatrick
Copy link
Contributor

Hey! I would like to set a maximum value of nested types so that I can raise a warning when it exceeds this value. I did some research and took a look at the NestingRule source code and from what I understood regarding the configuration object, it is not possible at this moment to achieve what I had in mind.
I don't want to simply turn off the rule. Is my previous suggestion something of interest for someone else?
@marcelofabri
Copy link
Collaborator

This is not possible currently but it certainly would be a welcome enhancement. Feel free to send a PR!

We probably could use two SeverityLevelsConfigurations, one for types and another one for statements.

@BalestraPatrick
Copy link
Contributor Author

@marcelofabri Hey! That would be great but unfortunately I don't have time to dig into the codebase at this moment. If anyone is interested, they are welcome to pick it up 😄

@sora0077 sora0077 mentioned this issue Mar 3, 2017
Merged
@marcelofabri
Copy link
Collaborator

This was implemented by @sora0077 in #1340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelofabri @BalestraPatrick