You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When refactoring code it's common to comment out tests that also require refactoring and one might forget to uncomment and refactor these tests before submitting a new patch set to Code Review. In the last two weeks I caught this issue twice when reviewing code. The rule would have thrown a violation to the developer before they could submit the code to Code Review.
This rule would be similar to #2190, but for Quick blocks instead of XCTest methods.
Provide several examples of what would and wouldn't trigger violations.
New Issue Checklist
Rule Request
When refactoring code it's common to comment out tests that also require refactoring and one might forget to uncomment and refactor these tests before submitting a new patch set to Code Review. In the last two weeks I caught this issue twice when reviewing code. The rule would have thrown a violation to the developer before they could submit the code to Code Review.
This rule would be similar to #2190, but for Quick blocks instead of XCTest methods.
Severity only.
Opt-in would be fine.
The text was updated successfully, but these errors were encountered: