Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different line numbers in rule type_body_length for subtypes #2293

Open
Jeehut opened this issue Jul 17, 2018 · 2 comments
Open

Use different line numbers in rule type_body_length for subtypes #2293

Jeehut opened this issue Jul 17, 2018 · 2 comments

Comments

@Jeehut
Copy link
Collaborator

Jeehut commented Jul 17, 2018

We would like to specify different line numbers to the type_body_length rule when it comes to subtypes in comparison to types. This could either be done by providing an option to the existing rule type_body_length or by creating a new rule named subtype_body_length.

Specifically, we would like to keep the SwiftLint default warnings and error values for type_body_length (which are set at 200 and 350 right now) but we would like to limit the length of subtypey to 20 (warning) and 35 (error).

I would be happy to implement this myself, but which of the two above ways do you think makes more sense? I'm guessing introducing a new rule will be the easier solution. Do you agree?

@marcelofabri
Copy link
Collaborator

I think having it as a separate rule would be easier to understand as a SwiftLint user.

@jslusser
Copy link

I agree - keep it separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants