Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Request: Protocol conformance order #2751

Open
2 tasks done
sindresorhus opened this issue May 9, 2019 · 0 comments
Open
2 tasks done

Rule Request: Protocol conformance order #2751

sindresorhus opened this issue May 9, 2019 · 0 comments

Comments

@sindresorhus
Copy link

sindresorhus commented May 9, 2019

New Issue Checklist

New rule request

  1. Why should this rule be added? Share links to existing discussion about what the community thinks about this.

Similar to the modified_order rule, it would be useful to be able to enforce the order of built-in protocols in a conformance. And also enforce that built-in protocols come first.

  1. Provide several examples of what would and wouldn't trigger violations.

Would trigger:

struct Foo: RawRepresentable, Hashable {}
struct Foo: CustomProtocol, Hashable {}

Would not trigger:

struct Foo: Hashable, RawRepresentable {}
struct Foo: Hashable, CustomProtocol {}
  1. Should the rule be configurable, if so what parameters should be configurable?

No

  1. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a rule as opt-in.

Enabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants