Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity-based validates_start_with_lowercase doesn't support disabling the check #5036

Closed
2 tasks done
auramagi opened this issue May 26, 2023 · 2 comments · Fixed by #5064
Closed
2 tasks done

Severity-based validates_start_with_lowercase doesn't support disabling the check #5036

auramagi opened this issue May 26, 2023 · 2 comments · Fixed by #5064
Labels

Comments

@auramagi
Copy link

New Issue Checklist

Describe the bug

  • Since 0.52.1 (Let validates_start_with_lowercase option in name configurations expect a severity #4970) the boolean setting for validates_start_with_lowercase is deprecated in favor of a severity-based setting
  • The default setting is error, so in spite of release notes saying that Not setting it disables the check, not setting it will in fact enable the check and result in errors on triggering lines
  • The effect of validates_start_with_lowercase: false is now impossible to be achieved in a non-deprecated way
@SimplyDanny
Copy link
Collaborator

Hm ... what would be a good semantic here to support disabling the check without the deprecation warning? I see two:

  • Accept warning, error and no/off where no/off disables the check
  • Accept false without a deprecation warning

And honestly, I don't like any of these much.

@Zim999
Copy link

Zim999 commented Jun 14, 2023

off makes most sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants