accessibility_label_for_image doesn't require a11y label with Image(systemName:)

[stjernegard]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Describe the bug

When opting in to use accessibility_label_for_image, I would expect to get a warning every time a default accessibility label is used, but there's no warning for missing labels when the image is an SF Symbol.

While this is documented behaviour in the rules, I consider it a bug because the rule is opt-in for people who want to have better accessibility labels and just describing the icon is not generally a good label.

It is true that some SF Symbols have default accessibility labels, like how plus has the default label "Add", many others simply fall back to the name of the icon, like clock.arrow.circlepath.

If others disagree, this might just be a feature request to allow us to also require a11y labels when Image(systemName:) is used.

[SimplyDanny]

@rcole34: You contributed the rule initially. That's why I'd like to hear your opinion on the request.

[rcole34]

I think when I was doing this initially I was trying to minimize false positives and since some SF Symbols do get default labels I erred on the side of not triggering errors for that constructor. In hindsight though I agree that it makes more sense for this rule to always require labels for system images — not only are there lots of symbols that don’t get default labels, but the default ones could often be improved upon and given more context (“Add ____” is often better than “Add” to be clear about what the plus adds).

Since contributing this rule I’ve actually joined the accessibility team at Apple, which means I’d have to go through some approvals to contribute to open source projects, but if someone wants to take this on I’d support this enhancement and think it should be pretty straightforward to remove the special case for allowing Image(systemName:)

[mildm8nnered]

I can handle this, I hope ...