Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate “undocumented.json” from “docs”? #754

Closed
SDGGiesbrecht opened this issue Feb 24, 2017 · 6 comments
Closed

Separate “undocumented.json” from “docs”? #754

SDGGiesbrecht opened this issue Feb 24, 2017 · 6 comments

Comments

@SDGGiesbrecht
Copy link
Contributor

Right now, CI, validation, change tracking, etc. that use tools like diff or git diff need to go to extra work to explicitly ignore each undocumented.json (and the docset .tgz that contains one), because source_directory causes output differences unrelated to the source code.

Also, is it wise to print the user’s username and file structure without notifying them—particularly into documents they are likely to publish? Some might see that as a security risk.

What purpose does source_directory currently serve? Is there a more consistent, more secure way of achieving that purpose?

@pcantrell
Copy link
Collaborator

The original rationale was to make it easy for developers — and especially for developer tools — to open the offending file.

It's the same reason why compilers, linters, and other build tools often emit full paths, though granted they usually send those paths to the console and not a file.

@SDGGiesbrecht
Copy link
Contributor Author

Yes, that makes sense.

Would it be reasonable to output undocumented.json separately from the docs folder, or at least stop producing duplicates inside the .docset and .tgz?

That would make it easier for those of us who want to prevent inadvertent publishing of undocumented.json.

@SDGGiesbrecht SDGGiesbrecht changed the title Remove "source_directory" from undocumented.json? Separate “undocumented.json” from “docs”? Feb 27, 2017
@jpsim
Copy link
Collaborator

jpsim commented Mar 9, 2017

I'd vote for keeping it in the output directory (docs/ by default) but not copying them into the .docset and .tgz.

@SDGGiesbrecht
Copy link
Contributor Author

I'd vote for keeping it in the output directory (docs/ by default) but not copying them into the .docset and .tgz.

May I try to implement this, or is more review required first?

@jpsim
Copy link
Collaborator

jpsim commented Mar 23, 2017

If you want to do this, go for it!

@SDGGiesbrecht
Copy link
Contributor Author

This is now implemented on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants