-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSSet makes Jazzy forget the rest of the line #910
Comments
I was using Xcode 8 in this case because the framework we're building for is on Xcode 8. We have a newer version that's on Xcode 9, but that's not being released yet. I'll try it on Xcode 9.1 and see if that improves. In my case - it wasn't a scrolling issue as I checked the actual HTML being generated. |
I found an Xcode 8.0 install I'd forgotten about + this immediately recreated, it is a SourceKit bug to do with XML escapes that has been since fixed. Tentatively closing this issue - use Xcode 9. SourceKitten could probably work around this but it's not that pretty.
|
I am using Xcode 9.1 - still same issue. Unless jazzy is somehow using Xcode 8 still - but I have my command line tools set to 9.1. |
You're right, sorry about that! The Swift bug is still there in master. If you have a doc comment the XML escaping goes wrong; if you do not have a doc comment it is fine. |
Thanks for fixing this @johnfairh. Will you update SourceKitten here or would you like me to do that? |
I will give it a shot. |
Fixed in master. |
Given our framework, we have this protocol line:
- (void)myObject:(nonnull MyManager *) myManager crossedLimitBoundariesWithExitedZones:(nullable NSSet <MyLimit *> *)exitedLimits enteredZones:(nullable NSSet <MyLimit *> *)enteredLimits;
Jazzy produces the following for Swift:
optional func myObject(_ myManager: MyManager, crossedLimitBoundariesWithExitedZones exitedLimits: Set
If I switch it to an NSArray (which obviously doesn't work for us since this SDK is already in use), Jazzy produces the correct HTML.
Is this a Jazzy bug or is there a workaround that doesn't require changing the SDK itself?
The text was updated successfully, but these errors were encountered: