Apps built with the dynamic framework can't be submitted to App store

[pietbrauer]

Hey,

I tried to submit my beta app to the iTunes Store today but unfortunately a dialogue appeared that the Realm.framework contains non-public API usage.

Did you see that before or have an idea on how to deal with it?

[pietbrauer]

Sorry, I am using @Carthage and v0.87.4 of realm. Can it be that I was linking the Mac Framework?

[tgoyne]

Assuming Carthage built the framework correctly, using the OS X framework should fail to compile unless you've managed to compile against the iOS framework and link against the OS X framework (which is hard to get Xcode to do even when actively trying).

We don't have any direct calls to bzero, but calls to memset(..., 0, ...) sometimes get optimized to calls to platform-specific versions of bzero. I suspect it's just a mistake on Apple's part and they marked symbols that shouldn't be private as private, but I'll see if I can reproduce it and if so try to find a workaround.

[tgoyne]

Carthage doesn't handle the fact that we support building both static and dynamic frameworks with the same name very well, but it does seem to build things correctly.

[pietbrauer]

Thanks for the research! Unfortunately Carthage 0.2.2 doesn't fix the issue.

[tgoyne]

I've poked into this a bit, and the ___bzero calls appear to be compiler-generated for zero-initialized stack variables, so either we have a compiler setting wrong somewhere, or the blacklist is incorrect. Have you emailed appreview@apple.com to verify that it's supposed to be blacklisted?

[pietbrauer]

Nope not yet, was when I tried to upload a beta build so there is no pressure on this for me. Would you consider this as the next step or do you want to check the compiler thingy first?

[tgoyne]

I'll continue looking for issues on our end, but it would help if you emailed them.

[tonyarnold]

Guys, this is probably related: Carthage/Carthage#188

[pietbrauer]

Wow, thanks for finding it!

[alanjrogers]

@tonyarnold I don't think that's related. The carthage issue is that built artefacts in Carthage.build contain x86_64 and i386 architectures that are rejected by the app store :(

[jpsim]

@alanjrogers that's the same issue we're having here.

In a nutshell, we're currently including simulator and device symbols in a fat framework binary. In static libraries, Apple strips them out as part of the archive process, but they don't yet do this for dynamic libraries.

This is a bug that apple should fix. But in the meantime, we need to find a work-around. One way would be to have 2 frameworks (1 for simulator, 1 for devices). Another option could be to have an archive build phase to strip out the simulator symbols.

I'm curious to see what solution the Carthage people come up with.

[jspahrsummers]

I've filed a Radar about this: rdar://19209161

[jpsim]

Thanks for the high quality radar, @jspahrsummers! Duped.

[jpsim]

Apple just closed my radar as a duplicate of rdar://18326724, so it looks as if someone else filed this long before we got to it. Which (I hope) increases the odds of Apple fixing it 🙏.

[jspahrsummers]

Ha, mine is still open. 😕

[jpsim]

Actually, I was wrong. My radar was closed as a dupe of @jspahrsummers'. Apple's world-class bug report UI confused me.