Allow aggregate operations to be used on key paths that start with a unary relationship #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unary relationship.
The constraint is now that the key path must traverse a to-many
relationship, but it is no longer required to be the first key in the
path.
This allows for the following queries that were formerly rejected:
ANY company.employees.age > 30
company.employees.@avg.age > 30
SUBQUERY(company.employees, $e, $e.age > 30).@count > 0
|
I think this resolves #2955. |
|
It does! |
| start = end + 1; | ||
| } while (end != NSNotFound); | ||
|
|
||
| return ColumnReference(prop, indexes); | ||
| if (isAggregate && !keyPathContainsToManyRelationship) { |
There was a problem hiding this comment.
these two conditions are essentially the same, so they could be merged into isAggregate != keyPathContainsToManyRelationship.
There was a problem hiding this comment.
They need to generate different error messages so I don't think this helps?
|
LGTM 👍 |
| @"Aggregate operations can only be used on key paths that include an array property"); | ||
| } else if (!isAggregate && keyPathContainsToManyRelationship) { | ||
| @throw RLMPredicateException(@"Invalid predicate", | ||
| @"Aggregate operations must be used on key paths that include an array property"); |
There was a problem hiding this comment.
I think it'd be clearer to say "Key paths that include an array property must use aggregate operations". The current wording could reasonably be interpreted to mean the same thing as the error above, when it's actually the opposite case.
|
👍 |
bdash
added a commit
that referenced
this pull request
Feb 15, 2016
…-link Allow aggregate operations to be used on key paths that start with a unary relationship
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraint is now that the key path must traverse a to-many relationship, but it is no longer required to be the first key in the path.
This allows for the following queries that were formerly rejected:
Fixes #2955.