Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sync.swift docs with deprecation warning. #6110

Merged
merged 4 commits into from May 24, 2019

Conversation

bmunkholm
Copy link
Contributor

No description provided.

@bmunkholm bmunkholm requested a review from tgoyne March 25, 2019 08:35
@tgoyne
Copy link
Member

tgoyne commented Mar 25, 2019

- warning is correct, and changing it to @warning will make the docs not render correctly inside Xcode.

@bmunkholm
Copy link
Contributor Author

Ah ok , so that works differently for objc which uses @?

@tgoyne
Copy link
Member

tgoyne commented Mar 25, 2019

Yes, objc and swift have different doc comment syntaxes.

@bmunkholm
Copy link
Contributor Author

Haha and I guessed I found the issue with the rendering.

Ok then we could just remove the year old note about it being experimental.

@bmunkholm
Copy link
Contributor Author

@tgoyne I fixed the wrong warning syntax. Is this good now?

@tgoyne tgoyne merged commit 321d9cc into master May 24, 2019
@tgoyne tgoyne deleted the bmunkholm/doc-deprecation branch May 24, 2019 17:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants