Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose private m_version for table #1323

Closed
nhachicha opened this issue Nov 13, 2015 · 2 comments
Closed

Expose private m_version for table #1323

nhachicha opened this issue Nov 13, 2015 · 2 comments
Assignees

Comments

@nhachicha
Copy link
Contributor

Fix realm/realm-java#1676
we need to expose m_version (in table.hpp) in order to implement a more fine-grained notification & avoid calling RealmResults (table_view) & RealmObject (Row) callbacks for every commit.

comparing the old & current value of m_version allow us to know if the new commit impacted our table_view/row, this should reduce the number of invocations to callbacks.

as discussed here #1254

@finnschiermer
Copy link
Contributor

We need some freedom for implementations in core. We can provide a guarantee that if the version of a table is unchanged, so is the table. The opposite is not true: the version may change even if the table is unchanged. Also, we define the table as being only the table, giving no guarantees as to changes to link targets.

@finnschiermer
Copy link
Contributor

Available as PR #1357

@finnschiermer finnschiermer removed the P1 label Nov 23, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants