Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-API] Google credentials does not support. both IdToken and AccessCode #5347

Closed
cmelchior opened this issue Mar 23, 2022 · 0 comments · Fixed by #5359
Closed

[C-API] Google credentials does not support. both IdToken and AccessCode #5347

cmelchior opened this issue Mar 23, 2022 · 0 comments · Fixed by #5359
Assignees

Comments

@cmelchior
Copy link
Contributor

Currently, the C-API only exposes:

RLM_API realm_app_credentials_t* realm_app_credentials_new_google(const char* id_token) RLM_API_NOEXCEPT;

But Google and ObjectStore support two different tokens:

AppCredentials::google(AuthCode(StringData(id_token).data()));
AppCredentials::google(IdToken(StringData(id_token).data()));

So we need an API that can distinguish between these. Maybe something like

RLM_API realm_app_credentials_t* realm_app_credentials_new_google_id_token(const char* id_token) RLM_API_NOEXCEPT;
RLM_API realm_app_credentials_t* realm_app_credentials_new_google_auth_code(const char* auth_code) RLM_API_NOEXCEPT;
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants