Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SyncProgress.transferred/transferable with estimate #1562

Closed
nirinchev opened this issue Mar 14, 2024 · 1 comment · Fixed by #1563
Closed

Replace SyncProgress.transferred/transferable with estimate #1562

nirinchev opened this issue Mar 14, 2024 · 1 comment · Fixed by #1563
Assignees
@nirinchev

Comments

@nirinchev
Copy link
Member

We want to merge that change in even if the actual progress notification work is not yet ready since it's a breaking change. This work will rely on the old values, just calculate progress based on the bytes.
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Mar 14, 2024

➤ PM Bot commented:

Jira ticket: RDART-972

@nirinchev nirinchev self-assigned this Mar 14, 2024
@nirinchev nirinchev mentioned this issue Mar 14, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nirinchev nirinchev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RDART-972: Prepare breaking change for progress notifications realm/realm-dart
1 participant
@nirinchev