Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler null check for when AndroidNotifier is closed (#4131) #4132

Closed
wants to merge 2 commits into from
Closed

Handler null check for when AndroidNotifier is closed (#4131) #4132

wants to merge 2 commits into from

Conversation

Zhuinden
Copy link
Contributor

@Zhuinden Zhuinden commented Feb 1, 2017

Fixes #4131 which occurs when async queries are not yet finished, but Realm instance is closed.

@Zhuinden
Copy link
Contributor Author

Zhuinden commented Feb 1, 2017

I don't think I've signed the contributor license agreement thing yet, though.

@zaki50
Copy link
Contributor

zaki50 commented Feb 1, 2017

@Zhuinden Can you add a test case to reproduce #4131?

@cmelchior
Copy link
Contributor

Hi @Zhuinden . Thanks a ton for this. Can you also add a changelog entry?

@Zhuinden
Copy link
Contributor Author

Zhuinden commented Feb 1, 2017

I'm trying to run library tests in general but I kinda got stuck with it ¬¬

com.getkeepsafe.relinker.MissingLibraryException: lib/unknown/librealm-jni.so
at com.getkeepsafe.relinker.ApkLibraryInstaller.installLibrary(ApkLibraryInstaller.java:85)
at com.getkeepsafe.relinker.ReLinkerInstance.loadLibraryInternal(ReLinkerInstance.java:180)
at com.getkeepsafe.relinker.ReLinkerInstance.loadLibrary(ReLinkerInstance.java:136)
at com.getkeepsafe.relinker.ReLinker.loadLibrary(ReLinker.java:70)
at com.getkeepsafe.relinker.ReLinker.loadLibrary(ReLinker.java:57)
at io.realm.internal.RealmCore.loadLibrary(RealmCore.java:59)
at io.realm.Realm.init(Realm.java:187)

I added a changelog entry, but I ran out of time on trying to add tests for now.

I can give a sample project that produces this errors though: https://github.com/Zhuinden/realm-error-4131

The errors occur when you press BACK or you rotate the screen.

@Zhuinden
Copy link
Contributor Author

Zhuinden commented Feb 9, 2017

I think #3834 will handle this

@Zhuinden Zhuinden closed this Feb 9, 2017
@bmunkholm bmunkholm removed the S:Review label Feb 9, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realm receives NPE when updating async queries after Realm is closed
4 participants