Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorCode is not correct #6364

Closed
cmelchior opened this issue Dec 7, 2018 · 0 comments · Fixed by #6379
Closed

ErrorCode is not correct #6364

cmelchior opened this issue Dec 7, 2018 · 0 comments · Fixed by #6379
Assignees
Labels

Comments

@cmelchior
Copy link
Contributor

cmelchior commented Dec 7, 2018

The enum names for the Realm Object Server error codes in ErrorCode.java seems to have diverged from their current meaning.

This is unfortunate as it is most likely a breaking change to fix it, but we need to update them regardless so they are accurate.

Example is BAD_SERVER_VERSION_DOWNLOAD(111) which is bad_changeset_header_syntax(111)


EDIT: This is actually more severe than that. Core reports errors using (category, code), but only the code is sent to Java, this means that some errors are not being mapped correctly. We need to fix this so error mapping are done using both the error code and category

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants