Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Event Notification System #4391

Open
takameyer opened this issue Mar 3, 2022 · 0 comments
Open

Refactor Event Notification System #4391

takameyer opened this issue Mar 3, 2022 · 0 comments

Comments

@takameyer
Copy link
Contributor

Problem

In our React implementation, we have run into an issue that occurs when multiple write transactions occur in tandem that cause the hooks to update. The issue is that the hooks will reregister their event listeners when they detect a change, and that it is potentially possible to be in a new write transaction when this subscription occurs.

See issue #4375

Solution

We would like to implement a solution similar to what the .NET SDK has in place. This solution will have a single subscription on object store that will process a queue of listener callbacks registered in user space. This allows the SDK code to be able to detect if it is in the middle of a write transaction, and can then process the queue after the current transaction is committed or terminated.

This will make a more robust notification system that will not crash if a listener is added during a write transaction.

How important is this improvement for you?

Would be a major improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant