Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize non-public API #56

Closed
sync-by-unito bot opened this issue Nov 9, 2020 · 2 comments · Fixed by #446
Closed

Internalize non-public API #56

sync-by-unito bot opened this issue Nov 9, 2020 · 2 comments · Fixed by #446
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 9, 2020

Move non-public API out of public accessible namespaces. 

Don't know if this is possible with our current module approach, but maybe a good time to re-evaluate that then. 

An option could be to just more everything to internal packages, which is at least hinting that it shouldn't be used, but could maybe be backed by opt in requirements https://kotlinlang.org/docs/reference/opt-in-requirements.html

@cmelchior
Copy link
Contributor

I suspect that we regardless need to move things to an io.realm.internal package, due to Java interop as everything with module visibility turns into public

@rorbech
Copy link
Contributor

rorbech commented Mar 17, 2021

Just for reference. There seems to be some discussion on whether to support -Xfriend-paths across modules or maybe hide @RequiresOptIn annotations to make them unintentionally discoverable in https://kotlinlang.slack.com/archives/C0B8PUJGZ/p1603379870021800?thread_ts=1602247378.011300&cid=C0B8PUJGZ and linked posts/issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants