Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename classes to match spec and move access token restricted features under user #6566

Closed
RealmBot opened this issue Jun 9, 2020 · 4 comments
Assignees

Comments

@RealmBot
Copy link
Collaborator

RealmBot commented Jun 9, 2020

No description provided.

@RealmBot
Copy link
Collaborator Author

RealmBot commented Sep 3, 2020

➤ Eric Mossman commented:

[~jason.flax]

  • I've finished the issue with "identifier" and isLoggedIn. There are consistently failing tests in testMongoAggregateAndCount and testDownloadRealmToCustomPath though. But these in the base v10 like Change Configuration.objectTypes property type #6703 also. Should I move forward and get everything in a reviewable PR or wait until new v10?
  • "access token restricted features" which features does this refer to?
  • The last thing I'd like to do is this: https://github.com/realm/realm-cocoa/blob/em/identity-refactor/Realm/RLMUser.mm#L46.
    But there's a chance I might miss something when trying to tell if a test is failing because of my changes vs. something in the base branch. I could create a ticket for pruning out the dead code in a different ticket and follow through with that after a new v10.

@RealmBot
Copy link
Collaborator Author

RealmBot commented Sep 3, 2020

➤ Jason Flax commented:

Access token restricted features is already complete. The last two remaining changes are:

For APIKeyAuth:

apiKeyAuth -> apiKeysXXX

And on EmailPasswordAuth

Change registerEmail -> registerUser

@RealmBot
Copy link
Collaborator Author

RealmBot commented Sep 8, 2020

➤ Eric Mossman commented:

For apiKeyAuth -> apiKeysXXX
Does this mean just change "Auth" to three X's in the method? Or something else?

@jsflax
Copy link
Contributor

jsflax commented Sep 8, 2020

It means to make it plural, do not worry about the X's, it was a holdover from generalising the name for the SDKs broadly.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants