Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This app is very unreliable on Nougat #8

Open
Mygod opened this issue Jul 3, 2017 · 19 comments
Open

This app is very unreliable on Nougat #8

Mygod opened this issue Jul 3, 2017 · 19 comments
Assignees
Labels

Comments

@Mygod
Copy link
Contributor

Mygod commented Jul 3, 2017

Almost every time I connected to Wi-Fi I need to start this app and start dhcp6c manually or it doesn't get a IPv6 address.

I'm suspecting that the issue is using a BroadcastReceiver for network changes is deprecated.

@realmar realmar added the bug label Jul 26, 2017
@realmar realmar self-assigned this Jul 26, 2017
@realmar
Copy link
Owner

realmar commented Jul 26, 2017

Hmm, starting from API level 24 broadcasts have to be registered using registerReceiver. Though you already implemented that in a PR. as I see it BroadcastReceiver is not deprecated.

It maybe has something to do with #6

Currently, I have no rooted phone available, so it will be difficult for me to debug. I'm trying to get one as soon as possible. (Maybe buying a cheap one for 40 bucks)

@Mygod
Copy link
Contributor Author

Mygod commented Jan 8, 2018

@realmar Are you still maintaining this project?

@Mygod
Copy link
Contributor Author

Mygod commented Jan 8, 2018

Because if not, I'm planning to rewrite this. :-)

@realmar
Copy link
Owner

realmar commented Jan 8, 2018

@Mygod Unfortunately, I'm not. So if you want to rewrite this app, just go ahead and do it. :)
Let me know where you will host the maintained version, so I can link it from this repo. (I assume you will continue development on your fork?)

@Mygod
Copy link
Contributor Author

Mygod commented Jan 8, 2018

That sounds like a good idea. Do you mind if I change package id for my rewritten project?

@realmar
Copy link
Owner

realmar commented Jan 8, 2018

Sure, I don't mind. However, keep in mind that it would be great to publish your version to the google play store. If you change the package id you would need to create a new app in the store, as google does not support renaming it. (Otherwise I would have renamed it myself long ago :P) If you keep the package id then I could just update the existing version. Though that's up to you how you wanna do it. :)

@Mygod
Copy link
Contributor Author

Mygod commented Jan 8, 2018

I know. However I feel like I will probably start anew (and probably copy a few lines from your repo) supporting only API 21+ (using its new Network API) so I think it's better to have end user to have the option to install both. However I'm currently a little short of time so that rewrite may take up to months to come. It would be great if you could push an update to recommend my app to API 21+ users then if you want to. :P

@realmar
Copy link
Owner

realmar commented Jan 8, 2018

Sure, this sounds great! Let me know when you publish your version, so I can update this repo and the app. :)

@aedicted
Copy link

Hello together,

I stumbled across this thread as I recently updated to Oreo on my Note 8 (N950FD) and now try to get the DHCPv6 client running again ever since.

For reasons probably only god knows, J:COM in Japan gives customers only one single IPv6 address where others hand out /56 or even /48 ranges. Hence I'm stuck with DHCPv6.

While realmar's DHCPv6 client used to work halfway under Nougat and still does on my tablet using Lollipop, under Oreo I can't get an IPv6 address not matter what I try (manual invoke, all interfaces, etc.).

Furthermore, at least in conjunction with Magisk root there is the strange phenomenon that the DHCPv6 client gets stuck displaying "requesting root permissions" when one switches between this and other apps. Only way to exit is to close the app and restart it where it gets the access rights granted right away. Busybox is installed of course.

So any update of this promising app by either of you guys would be greatly appreciated.

@Mygod
Copy link
Contributor Author

Mygod commented Jun 13, 2018

Hey @realmar, I have rewritten the app here: https://github.com/Mygod/DHCPv6-Client-Android

At this point I just only got it working and there are still more work to do. But before that, could you tell me should I distribute my code under GPLv3 as well? I didn't use any code you wrote besides your icon and wide-dhcpv6 is distributed under BSD and AOSP is distributed under Apache 2.0.

Also it'd be great if you can share the design source of your icon with me as well. Thanks. 😄

EDIT: I see why you used GPLv3 license because Fairphone is distributed under GPLv2. But the new version compiles wide-dhcpv6 source directly (with a module copied from AOSP).

@realmar
Copy link
Owner

realmar commented Jun 13, 2018

Hey @Mygod, thanks for sharing it looks very promising! :D

As you noticed I used scripts from Fairphone, so I needed to license it as GPL. As I see it you don't use any Fairphone source and also none of my source (except for the two things you mentioned), so you don't need to license it as GPLv3.

I created the icon with GIMP. Unfortunately, I lost the source file (the .xcf) so you would need to use the existing one or create a new. (Should have checked that in :P) For the design of the icon, I just experimented with GIMP until I created something I like.

Are you planning to publish your app in the app store?
If you feel you reached a point where you want to publish/release the app, write me so I can promote it in this GitHub project and people are directed to your app. (As I don't maintain this Project anymore)

@Mygod
Copy link
Contributor Author

Mygod commented Jun 14, 2018

Thanks! I published the first alpha release. I'm considering hitting some app stores when I have a new icon.

@realmar
Copy link
Owner

realmar commented Jun 14, 2018

Sure, just let me know then I'll put the link in the repo!
I'll also try your fork if I have time! (Currently, I have no rooted phone, so I need to get my old nexus and see what I can do) :D

@Mygod
Copy link
Contributor Author

Mygod commented Jul 22, 2018

@realmar Hey I think it's ready to go now. (0.1.3) Configurations are kind of minimal at this point, mainly because I don't know what would be useful to add. 😛

@realmar
Copy link
Owner

realmar commented Jul 22, 2018

@Mygod Looks very good, I think the project is in good hands with you! I added a deprecation notice to this repo and linked to yours! :D
As for the options, I still have no rooted phone, so can't say anything. :P

@aedicted
Copy link

I can report that the app works on my Note 8 under Android 7.1.1 (Nougat) in conjunction with SuperSU at least. :)

Many thanks for that update!

@realmar: interesting that a developer decides not to use root access while this is what enables actually being able to use the phone. At least with Samsung, I couldn't care less about that retarded Knox-Trigger - their service is lousy and virtually non-existent either way so hardly any real loss there.

@Mygod
Copy link
Contributor Author

Mygod commented Jul 22, 2018

Uh I actually didn't write any tests for my fork lol. The only tests run by Travis are lint checks I believe.

@aedicted I hope you are talking about my fork 🤣. If not, feedbacks are welcome.

@realmar
Copy link
Owner

realmar commented Jul 22, 2018

Oops, removed that line.

@aedicted Not sure what you mean, I currently don't have the need for root and use SLAAC in IPv6 environments.

@aedicted
Copy link

@Mygod yes, I am. :)
@realmar no worries, wasn't supposed to be any critic. I am just surprised that a developer can survive without root (and thus no decent backups, ad blocking, advanced routing, etc. possibilities either), that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants