Update to 1.19 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the PR for the new changes in Forge 41.0.64. While these changes were not strictly necessary for the mod to work, it's still good to already adapt them now, because |
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straight-forward update to Minecraft 1.19. There were some changes to registries done from Forge's side due to changes in vanilla, so I've moved registration from events to deferred registers. While registration via an event
and using
ObjectHolders is still possible, I feel like deferred registers are much easier to maintain. If you don't want this change, let me know and I'll revert to event registration.Additionally, I added eclipse files to the .gitignore, and updated the Gradle wrapper to Gradle version 7.4.2.
Do note, that because there is no 1.19 branch on this repo, you'll need to create one and change the target branch of this PR before merging.