Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Should babel-preset-airbnb be in dependencies? #148

Closed
sdeleon28 opened this issue Oct 26, 2017 · 1 comment
Closed

Should babel-preset-airbnb be in dependencies? #148

sdeleon28 opened this issue Oct 26, 2017 · 1 comment

Comments

@sdeleon28
Copy link

I'm trying the master branch of the project directly from github to work around #139. When I run jest I get Couldn't find preset "airbnb" relative to directory "/path/to/project/node_modules/react-native-mock".

Should this dependency be in dependencies instead of devDependencies so that it gets installed when react-native-mock is installed via npm/yarn? Why does this even fail at runtime? Shouldn't all babel-related stuff be done with after build?

@sdeleon28 sdeleon28 changed the title Should babel-preset-airbnb be a in dependencies? Should babel-preset-airbnb be in dependencies? Oct 26, 2017
@sdeleon28
Copy link
Author

I've realized this is only a problem because I yarnd the lib directly from GitHub (because I needed to use master). Jest was diving into node_modules and transpiling modules in place. Since there was a .babelrc file in there, it tried to use it. This shouldn't happen via standard npm installs because the .babelrc is properly ignored in .npmignore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant