Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causing: Rename Node-Effects and Edge-Effects #74

Open
Holger-Bartel opened this issue Feb 21, 2024 · 0 comments
Open

Causing: Rename Node-Effects and Edge-Effects #74

Holger-Bartel opened this issue Feb 21, 2024 · 0 comments

Comments

@Holger-Bartel
Copy link
Contributor

Holger-Bartel commented Feb 21, 2024

This issue is for Causing.

Because of an historical notation, see https://realrate.ai/download/publications/RealRate%20Kausalanalyse%20mit%20NN.pdf, we use names and variable names that are too complicated from our point of view today. See See Sections 3.3 Exogene finale Effekte, 3.4 Endogene finale Effekte, and 4.3 Partieller, totaler und finaler Graph. So we should rename the variables in the public Causing repository https://github.com/realrate/Causing like this:

Node effects

exj_indiv -> xnodeeffect
eyj_indiv -> ynodeeffect

exj_indivs -> xnodeeffects
eyj_indivs -> ynodeeffects

Edge effects

eyx_indiv -> xedgeeffect
eyy_indiv -> yedgeeffect

eyx_indivs -> xedgeeffects
eyy_indivs -> yedgeeffects

Also, please check, if we use those names in the RealRate-Private repository.

@Holger-Bartel Holger-Bartel changed the title Rename Node-Effects and Edge-Effects Causing: Rename Node-Effects and Edge-Effects Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant