'Revolve a selected sketch' tool sometime make mistake in part design workbench.

[LeoBinsc]

'Revolve a selected sketch' tool sometime make mistake in part design workbench.
i have two case to show the mistake.
one case.
i create first sketch and draw a line Parallel to y axis.
next, i create second sketch and draw a rectangle.
then i use 'Revolve a selected sketch' tool to create a ring.
but sometime it work,sometime it makes mistake .

another case .
i pad a new sketch which draw a rectangle.
i select the top face and use 'Revolve a selected sketch' tool, but it has wrong result .
it sames nothing has changed.

i use the latest version.
sometime the tool is work well, but not all the time.
you can make same mistake with my step which is in the following web site.
and some picture and gif which shows detail are in this website.
i think the groove tool or undo tool has problem.
https://forum.freecadweb.org/viewtopic.php?f=8&t=61714

[luzpaz]

@LeoBinsc please add you full About info to the OP

[LeoBinsc]

OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 2021.717.24301 +3627 (Git)
Build type: Release
Branch: LinkStage3
Hash: f63a5ea7b459872a3798027df0ff25e776524859
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: Chinese/China (zh_CN)

i find more detail about groove.
groove have mistake when deal with same place twice.
https://forum.freecadweb.org/viewtopic.php?f=20&t=61714&start=20

[realthunder]

Hmm... this is quite a curious case. I find that Revolve and Groove misbehave if I just use the sketch in your posted file (attached below). But if I manually recompute your sketch once, then both Revolve and Groove works as expected. There must be some very obscure bug hidden somewhere causing the sketch shape in some invalid state, so to speak. Need further investigation. Can you think of anything special you've done with the sketch (the one with the rectangle)?

part design019.zip

[LeoBinsc]

part design is also wrong result.
the center of ring should be air .
but the center circle of bottom is surface.
it should be a Hollow ring.
if your program have right result , maybe our environment of computer are different.
just said this by part design 19.
my other files shows the program of revolve and groove have problems.
maybe you can try my last file, draw file like my pictures.

[LeoBinsc]

rectangle in xy sketch which raise above 20mm in z order , is also has wrong result after revolve by x axis turn 90 degree.
i will talk about it .
the Correct cross section is next picture.

but do this ,you will have wrong result.



turn order with x axis has more issues than y axis.

[LeoBinsc]

when z >0 or z < 0, revolve the sketch ( with x axis) which rectangle Intersects the X axis in the top view, the program allow, but sometime Not handled well. because it is more difficult ,maybe have Overlapping area to Calculation and display.
when z=0,revolve the sketch which rectangle Intersects the X axis in the top view, the program forbid this situation.
so delay solve it, and wait new OCC version is a good idea.

[realthunder]

There is something weirdly wrong with your FreeCAD, settings maybe. The saved sketch shape seems messed up. It can't be used to do any operation, even for a simple Pad. Please post your settings in C:/users/<you_user_name>/AppData/Roaming/FreeCAD/link.user.cfg.

[LeoBinsc]

link.user.cfg.zip
i use master and linkstage3 in my computer.
so in the folder,there has all configuration file.
i just have changed mod folder.

[LeoBinsc]

this picture show the same as rectangle in xy sketch which raise above 20mm in z order.
turn around this rectangle have Overlapping area to Calculation and display.

[LeoBinsc]

i think the key is ,if revolve the sketch with x axis ,the pattern should be On one side of the x-axis, which means y>0 or y<0 all of the pattern. if the pattern contain y > 0 and y<0, there will have have Overlapping area. of course z Not equal to 0 .
if z =0,means the default xy sketch. the pattern contain y > 0 and y<0 is forbidden .
so when z of xy sketch Not equal to 0, revolve x axis intersects the sketch should be announce when the pattern contain y > 0 and y<0 . as the same ,when z of xy sketch Not equal to 0, revolve y axis intersects the sketch should be announce when the pattern contain x > 0 and x<0 .

[LeoBinsc]

revolve the xy sketch(z=0) with x axis, one pattern can not connection first with third or fourth quadrant ,also can not connection second with third or fourth quadrant.
revolve the xy sketch(z not equal to 0) with x axis should have same forbid.

[realthunder]

I still can't reproduce your problem with your setting. I also tried with the exact same Window release image. Maybe you didn't get what I mean by recomputing the sketch. Please check out the screencast below. Without manually recompute the sketch first, I can't use it to do anything. Even a simple Pad will fail. But are you telling me you can use it fine, I mean apart from some Revolve/Groove anomaly?

Peek.2021-09-01.17-19.mp4

[LeoBinsc]

you just raise the xy sketch up 20mm , it is necessary to select x axis to revolve.
because when z = 0, the program announce revolve x axis intersects the sketch. (of course use this pattern)
and do step my picture shows.

[LeoBinsc]

the program can not solve the revolve which create Overlapping area , maybe it is useless.
so i suggest forbid this situation.

[LeoBinsc]

it is work well except the situation of raise sketch up and revolve the sketch (which cross over x axis ) with x axis.
add a exception to solve this situation.
because this situation is useless.

[LeoBinsc]

and even this situation can be repair ,split the pattern with x axis, and move upper pattern a big distance toward x direction.
then you can find there has Overlapping area In the X direction . just delete the distance of upper pattern in the x direction.
the Overlapping area Synthesize one，then it is the correct result。

[LeoBinsc]

i put a gif to show this mistake.

[LeoBinsc]

suggest