Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling auto focus on numerical inputs [upstream] #84

Closed
ceremcem opened this issue Sep 10, 2018 · 4 comments
Closed

Disabling auto focus on numerical inputs [upstream] #84

ceremcem opened this issue Sep 10, 2018 · 4 comments

Comments

@ceremcem
Copy link
Collaborator

Do you think disabling auto focus on numerical inputs which causes accidental data changes is hard to implement? It's clearly an upstream bug, but here are some promising searches: https://forum.freecadweb.org/viewtopic.php?f=3&t=30772

@realthunder
Copy link
Owner

I think it is a much less a problem in my branch, as every property change using property editor is undoable.

@ceremcem
Copy link
Collaborator Author

every property change using property editor is undoable.

A property change is undoable if and only if we notice the change (while scrolling in the property window, a change might be missed)

@realthunder
Copy link
Owner

I have changed property editor behavior. Please try it. If it works well, I'll submit a PR upstream.

@ceremcem
Copy link
Collaborator Author

According to first tests it works nicely.

My reproduction steps for the old behavior are as follows:

  1. Click an object (A), navigate property window, change its Placement.x
  2. Click another object (B)
  3. Scroll down and up in the property window
  4. You'll accidentally change B object's Placement.x eventually
  5. Same goes for any newly clicked objects

With this patch this behavior seems to fixed and if you click to edit Placement.x and then another object (or outside), the focus is removed from the input which makes further navigation safe.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants