Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve aspect ratio when generating with only one of -w/-h #38

Closed
jhrcek opened this issue Dec 11, 2019 · 1 comment
Closed

Preserve aspect ratio when generating with only one of -w/-h #38

jhrcek opened this issue Dec 11, 2019 · 1 comment

Comments

@jhrcek
Copy link
Collaborator

jhrcek commented Dec 11, 2019

Use case: I want to generate an animation with a script based on reanimate.
I want to specify just one dimension, so I run

./script.hs render -w 100

Expected behavior:
the height is calculated so that aspect ratio of the animation is preserved AND I don't have to do manual calculation to determine how much I should shrink the height to preserve aspect ratio.

Actual behavior:
the height remains at default value (1440) so the output looks like 1440x100 noodle :-)

Would you agree that if exactly one of -w / -h is provided, the other should be recalculated? If yes, I can do a PR implementing that.

@lemmih
Copy link
Member

lemmih commented Dec 11, 2019

Agreed, no one wants a noodle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants