Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying crossfade crash reaper #1638

Closed
DuskAudio opened this issue May 23, 2022 · 6 comments · Fixed by #1639
Closed

Applying crossfade crash reaper #1638

DuskAudio opened this issue May 23, 2022 · 6 comments · Fixed by #1639
Labels

Comments

@DuskAudio
Copy link

DuskAudio commented May 23, 2022

This issue has been around for a while, at least for me.
When i try to apply a crossfade to multiple media items and there are lanes hidden for that track , reaper crashes.
The action im using is SWS/AW: Fade in/out/crossfade selected area of selected items.
Event log says this:
Faulting application name: reaper.exe, version: 6.5.8.0, time stamp: 0x62858e81
Faulting module name: reaper_sws-x64.dll, version: 2.13.1.0, time stamp: 0x6276840f
Exception code: 0xc0000005
Fault offset: 0x0000000000107f6e
Faulting process ID: 0x2184
Faulting application start time: 0x01d86ed48efd4fc5
Faulting application path: C:\Program Files\REAPER (x64)\reaper.exe
Faulting module path: C:\Users\pedro\AppData\Roaming\REAPER\UserPlugins\ reaper_sws-x64.dll
Report ID: 59bda609-b3be-46e1-ac25-91064ed58d6f
Faulting package full name:
Faulting package-relative application ID:

Reaper forum thread:
https://forum.cockos.com/showthread.php?p=2561673#post2561673

@nofishonfriday
Copy link
Collaborator

@cfillion I see you've already reproduced in the forum thread, thanks.
But generally, apart from the exception code (access violation) , can we actually decipher anything from the fault offset (if so, how?)

@DuskAudio
Copy link
Author

The steps were.
Creating a new track, recording some takes of an acoustic guitar, making some comps and then trying to crossfade the final comp,
I remember having this issue before, never thought about posting in the forum.

@cfillion
Copy link
Collaborator

cfillion commented May 23, 2022

@nofishonfriday The fault offset points to the exact instruction that crashed:

  1. Install the same build of SWS with the corresponding code checked out in git
  2. Debug reaper.exe in Visual Studio and, in the Modules window, for the SWS DLL:
    • Get its base address
    • Load debug symbols (.pdb for that exact build, in the artifacts list on AppVeyor only for 1 month after release so best to collect them)
  3. Add the base address to the fault offset
  4. Pause debugging and go to that address in the Disassembly window
  5. comisd xmm11,mmword ptr [rax] = compare two doubles, one of them indirect = exception code is access violation so pointer was invalid

comisd xmm11,mmword ptr [rax]

@nofishonfriday
Copy link
Collaborator

Wow, thanks.

@cfillion
Copy link
Collaborator

@cfillion cfillion added the bug label May 24, 2022
@DuskAudio
Copy link
Author

I confirm this is fixed with this version. Thank you for the fix and for ultra fast reply. This means a lot for the end user ;) Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants