New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a audio preview API #1702
Merged
Merged
Add a audio preview API #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
cfillion
force-pushed
the
preview-api
branch
2 times, most recently
from
November 6, 2022 02:59
4ce5abe
to
870f1d3
Compare
cfillion
force-pushed
the
preview-api
branch
2 times, most recently
from
November 6, 2022 04:25
154e569
to
65f2f37
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cfillion
force-pushed
the
preview-api
branch
4 times, most recently
from
November 7, 2022 00:50
a071913
to
42b0392
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cfillion
force-pushed
the
preview-api
branch
from
December 19, 2022 23:18
6d6759b
to
4ef1b67
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Works on a PCM_source* directly, unlike BR_SetMediaSourceProperties which requires a MediaItem_Take*.
✅ Build sws 867-master completed (commit 30f96fefc7 by @cfillion) Windows 64-bitWindows 32-bitmacOS x86 64-bitmacOS x86 32-bitmacOS ARM 64-bitLinux x86 64-bitLinux x86 32-bitLinux ARM 64-bitLinux ARM 32-bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes REAPER's source preview API with additional features:
Adds these features compared to the existing preview functions in js_ReaScript API:
Adds CF_PCM_Source_SetSectionInfo for previewing in reverse or limit the length (without requiring a
MediaTake
, unlikeBR_SetMediaSourceProperties
).Test/demo script at https://gist.github.com/cfillion/7718bd7d3566a94c308ca7a5fdee8105.