cycle action editor - apostrophe

[tohubohu38]

in the cycle action editor, could you please add the possibility of putting an apostrophe in the title of a cycle action?
(it's for the langpack)

thanks

[cfillion]

Yes, I think that would be OK (but will need to double-check on Windows to be sure). Single and double quotes have special meaning for Windows and SWELL's .ini parser however that is only if at the start and end of the value. This is never the case for cycle action names.

The cycle action editor currently accepts quotes as part of the command names. There does not seem to be a reason to inconsistently disallow them for only the cycle action's name.

The limit for ' and " was added in d5d5f0c and for ` in 71ef5f3.

[tohubohu38]

thks
how do I test?
where is the sws pre release file please?
thanks

[cfillion]

Are you on Windows? If so, try creating a cycle action with these two commands ("a'b`c" and 40001) in that order:

Apply then restart REAPER. Check if the two commands loaded correctly.

In S&M_Cyclaction.ini it should be like this (except for the action number and the action name):

Action10=Test Cycle|"a'b`c"|40001|

If that works there shouldn't be a problem allowing those characters in the cycle action names as well.

[tohubohu38]

I'm sorry but I don't understand much.
I tested on mac before sending the issue. and not on windows
and it gave me a warning message when I wrote - ...l'enveloppe... - in the title of a cycle action.

[cfillion]

Done, I've checked on Windows and it works as expected. There will be builds you can try out in the pull request linked above (in a hour or so).

[tohubohu38]

thank you very much
where can I download the build please?
thanks

[cfillion]

The download links are in @AppVeyorBot's comment in the pull request #1798.