Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless systemd files in rescue/recovery system when no systemd is used #1013

Closed
jsmeix opened this issue Sep 28, 2016 · 1 comment
Closed

Comments

@jsmeix
Copy link
Member

jsmeix commented Sep 28, 2016

The contents of
skel/default/etc/systemd
skel/default/run/systemd
skel/default/usr/lib/systemd
skel/default/var/run/systemd
get copied into the rescue/recovery system
regardless if systemd is actually used or not, see
#1011 (comment)

This makes the rescue/recovery system bigger than
needed when no systemd is used.

I think I could enhance rescue/default/01_merge_skeletons.sh
to not copy systemd files into the rescue/recovery system
when no systemd is used.

On the other hand I wonder if nowadays this would provide
a real benefit for the users because nowadays systemd
is basically used on all systems.

@jsmeix jsmeix added this to the Rear future milestone Sep 28, 2016
@jsmeix jsmeix self-assigned this Sep 28, 2016
@jsmeix jsmeix removed this from the Rear future milestone Sep 28, 2016
@jsmeix
Copy link
Member Author

jsmeix commented Sep 28, 2016

According to
#1011 (comment)
not copying those systemd files into the rescue/recovery system
when no systemd is used could at most save about 236K
which is only about 0.067% of the 342M that the recovery system
has on my SLES12-SP2 test system, see
#1012 (comment)

With the same argument as in
#1012 (comment)

From my current point of view that is too little benefit
compared to the additional effort and compared to
the additional risk to mess up something subtle
in the recovery system...

I close this issue as "won't fix".

@jsmeix jsmeix closed this as completed Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant