Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of using "sfdisk" #1107

Closed
jsmeix opened this issue Dec 6, 2016 · 3 comments
Closed

Get rid of using "sfdisk" #1107

jsmeix opened this issue Dec 6, 2016 · 3 comments
Assignees
Milestone

Comments

@jsmeix
Copy link
Member

jsmeix commented Dec 6, 2016

I think we should try to get rid of using partitioning tools
that do not support GPT and large partitions because
otherwise I fear there will be and endless sequence
of more and more problems in ReaR in the future.

In particular "man sfdisk" reads:

sfdisk doesn't understand the GUID Partition Table
(GPT) format and it is not designed for large partitions.
In these cases use the more advanced GNU parted(8).

Cf.
#1106 (comment)

Currently "sfdisk" is called in
usr/share/rear/layout/save/GNU/Linux/200_partition_layout.sh
usr/share/rear/finalize/Linux-ppc64/200_install_yaboot.sh
usr/share/rear/finalize/SUSE_LINUX/ppc64/200_install_yaboot.sh
and "sfdisk" is mentioned in comments in
usr/share/rear/lib/mkrescue-functions.sh
and "sfdisk" is listed as REQUIRED_PROGS or PROGS in
usr/share/rear/conf/Linux-i386.conf
usr/share/rear/conf/Linux-ia64.conf
usr/share/rear/conf/Linux-ppc64.conf
usr/share/rear/conf/Linux-ppc64le.conf

@jsmeix jsmeix added cleanup enhancement Adaptions and new features labels Dec 6, 2016
@jsmeix jsmeix added this to the Rear future milestone Dec 6, 2016
@jsmeix jsmeix self-assigned this Dec 6, 2016
@gozora
Copy link
Member

gozora commented Dec 6, 2016

Btw. same applies to fdisk (which seems not to be currently used in ReaR code ;-) )

fdisk does not understand GUID partition tables 
(GPTs) and it is not designed for large partitions.  
In these cases, use the more advanced GNU parted(8).

@jsmeix
Copy link
Member Author

jsmeix commented Dec 13, 2016

Probably "sfdisk" is still needed for NTFS support
to get NTFS related data from a 'msdos' partitioned disk
and sgdisk could be used for a 'gpt' partitioned disk, cf.
#1078 (comment)

@gozora
Copy link
Member

gozora commented Dec 13, 2016

Yes, at least until we have complete code for that NTFS/Windows stuff, I'd put this "on hold".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants