Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELinux autorelabelling possibly inconsistently implemented #1404

Closed
jsmeix opened this issue Jul 6, 2017 · 2 comments
Closed

SELinux autorelabelling possibly inconsistently implemented #1404

jsmeix opened this issue Jul 6, 2017 · 2 comments
Labels
Milestone

Comments

@jsmeix
Copy link
Member

jsmeix commented Jul 6, 2017

While working on #1401
I noticed that SELinux autorelabel stuff in ReaR
is possibly inconsistently implemented.

Currently it seems SELinux autorelabelling is implemented
in some backup method specific scripts, namely:

# (cd usr/share/rear/ ; find . | xargs grep -l '\.autorelabel' )

./backup/NETFS/GNU/Linux/600_start_selinux.sh
./backup/NETFS/GNU/Linux/620_force_autorelabel.sh
./backup/RSYNC/GNU/Linux/610_start_selinux.sh
./backup/RSYNC/GNU/Linux/620_force_autorelabel.sh
./prep/NETFS/GNU/Linux/200_selinux_in_use.sh
./prep/RSYNC/GNU/Linux/200_selinux_in_use.sh
./restore/FDRUPSTREAM/default/270_selinux_considerations.sh
./restore/NETFS/default/500_selinux_autorelabel.sh
./restore/default/500_selinux_autorelabel.sh
./restore/BLOCKCLONE/default/500_selinux_autorelabel.sh

I am not at all a SELinux expert but I think
SELinux stuff is generic functionality that should
be implemented in a generic ReaR script so that
SELinux stuff (in particular SELinux autorelabelling)
works independent of the backup method.

@jsmeix jsmeix added cleanup enhancement Adaptions and new features labels Jul 6, 2017
@jsmeix jsmeix added this to the ReaR future milestone Jul 6, 2017
@schlomo
Copy link
Member

schlomo commented Jul 6, 2017

Maybe the script in restore/default makes all the other files obsolete?

@github-actions
Copy link

github-actions bot commented Jul 1, 2020

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants