Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypting the backup tarball on USB Devices (possible enhancement) #195

Closed
HannesLink opened this issue Jan 31, 2013 · 6 comments
Closed
Assignees
Labels
enhancement Adaptions and new features

Comments

@HannesLink
Copy link
Contributor

Hello,

due to some special security requirements at our site we are forced to encrypt all backups on external media. I've wrote a quick and dirty patch that changes the tar commands in backup/NETFS/default/50_make_backup.sh and restore/NETFS/default/40_restore_backup.sh so that the tarball is des3 encrypted using openssl.

Do you think this could be a possible enhancement for rear? Please let me know where I can upload the patch.

Best regards,
Hannes

@ghost ghost assigned gdha Feb 1, 2013
@gdha
Copy link
Member

gdha commented Feb 1, 2013

You may upload your patch into a gist (https://gist.github.com/)

@HannesLink
Copy link
Contributor Author

Done, you can find the patch at: https://gist.github.com/4691079
Please let me know if this could be integrated in future releases of rear.

@gdha
Copy link
Member

gdha commented Feb 1, 2013

Thanks for the patch - I had a quick look and you encrypt/decrypt within the whole BACKUP=NETFS workflow, but only check the keys with OUTPUT=USB? I think OUTPUT=ISO should also be included. Perhaps, it would make sense to move the rear/verify/USB/NETFS/default/60_check_encryption_key.sh to rear/verify/NETFS/default/60_check_encryption_key.sh?

@dagwieers
Copy link
Contributor

@HannesGit It is easier to make a pull request rather than work with patches. The benefits are myriad:

  • Pull requests can be discussed (and even commented per line if need be)
  • Pull requests can be updated (when the branch is changed, committed and pushed)
  • Pull requests are merged more easily directly, including any recent changes

Working with git requires some deeper understanding, but you can also modify files through Github itself and a pull-request is automatically made for you. So if you are fixing a single file, or modifying documentation, you don't even have to use the git command line)

@gdha
Copy link
Member

gdha commented Feb 11, 2013

@gdha
Copy link
Member

gdha commented Feb 25, 2013

tested it myself - it works correctly

@gdha gdha closed this as completed Apr 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features
Projects
None yet
Development

No branches or pull requests

3 participants