-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested tweaks to the initial rear recover
menu
#3011
Comments
I think you are talking about the user dialog
or
This dialog is implemented in This dialog only appears in so called "migration mode"
The second choice of this dialog
only appears when in migration mode ReaR autodetects
in layout/prepare/default/300_map_disks.sh via
where the is_completely_identical_layout_mapping function This means the is_completely_identical_layout_mapping function
/dev/sdb and /dev/sdc get interchanged by the mapping. BUT: When no disks get interchanged by the mapping In other words: The usual cases when in "migration mode"
or when there are several target disks with same size like
The difference between
and
is that after
several subsequent "migration mode" user dialogs appear
those subsequent "migration mode" user dialogs do not appear
i.e.
the "migration mode" is switched off. |
@danboid
My personal reasoning: Personally I feel a bit treated as if I was an idiot BUT: Often (basically always from my personal experience) From my personal experience the general root cause is |
Surely the use case / purpose for rear is backing up and restoring Linux based systems? That's what it is supposed to do right? If I'm mistaken then please correct me. |
Given that migration mode is often a source of problems, to me it also seems preferable to offer the option that leads to switching it off, i.e. |
Yes, that makes perfect sense to me. |
@pcahyna My arguments: (1) As far as I implemented it (or at least I tried to implement it) (2) (3) Did you understand that an identical disk mapping The standard example where
When on the replacement virtual machine BUT: When on the replacement virtual machine In migration mode I would prefer to not rely blindly Instead in migration mode I prefer explicit user confirmation
cf. layout/prepare/default/250_compare_disks.sh (4) Recently I see more often that the wish appears here Since that time I worked primarily to make ReaR behave better I assume also Red Hat customers prefer when ReaR |
As far as I see things work OK for me
I had a 20 GiB sda system disk The original machine and the replacement machine are VMs. I did one test with a 20 GiB sda and 1 GiB sdb
I did another test with a 21 GiB sda and 1 GiB sdb
|
Stale issue message |
I'm pretty confident in saying that the philosophy of the rear devs is that rear should be as easy to use as possible and operate in the most obvious and straightforward way, which is why I decided to file this rather nitpicky suggestion regarding the first menu the user is presented with when they run
rear recover
.I would expect that the most common use case for rear is when a user is restoring a backup onto the same machine with the same (disk) config versus restoring the backup onto the same machine with a slightly different disk config or another machine entirely. I would imagine this is how it gets used the majority of the time and so in that case, when the user is restoring a rear backup onto the same machine with the same disk config, the option they most likely want to pick from the first
rear recover
menu is awkwardly option #2, "Confirm identical disk mapping and proceed without manual configuration" so my first suggestion is that this should be moved to option #1 because its the most likely option the user wants and so should logically be the first suggestion and menu item, ie the "default" option.Another reason I'm suggesting this tweak is that I presumed option 1 was what I should be using on my first few goes with rear and not only does option 1 make
rear recover
more complicated than it needs to be in most cases, it doesn't currently doesn't work for me and so I'll be opening a separate ticket for that.My other suggested tweak for this menu is changing the wording of what is currently the first option (which I think should be the second option)- "Confirm disk mapping and continue
rear recover
". What does "continue rear recover" mean to the new user? Not very much. How does this option differ from ""Confirm identical disk mapping and proceed without manual configuration" - it is not made clear from the options current label. I think this option should be called something more like "Confirm disk mapping and configure recovery options."The text was updated successfully, but these errors were encountered: