-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moment.js to peerDependencies #18
Comments
i think the users should try to add
a better solution is to include |
Interesting. I guess I was thinking on cases where you start a project from scratch, but It seems other projects in a similar situation like |
moment
should be in dependencies
@jchavarri FYI this is now added |
Really minor :) for consumers to get the originalEdit: better add it tomoment
package when downloading the bindings and avoid version mismatches, it should be better moved todependencies
(now it's indevDependencies
).peerDeps
, see below 👇The text was updated successfully, but these errors were encountered: