Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

complete syntax highlighting #5

Closed
17 tasks
ghost opened this issue Sep 30, 2016 · 3 comments
Closed
17 tasks

complete syntax highlighting #5

ghost opened this issue Sep 30, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 30, 2016

Remaining tasks:

  • Reason
    • classes and objects
      • class
      • copies
      • inherit
      • initializers
      • private methods
      • recursive classes
      • self reference
      • virtual methods
    • patterns
      • polymorphic variant wildcards
    • terms
      • coercions
      • string indexing
    • types
      • subtyping
  • OCaml
    • for
    • labels
    • list literals
    • objects
    • while
@jmmk
Copy link

jmmk commented Nov 16, 2016

Not sure if this fits here or is a separate issue, but it looks like multiline strings aren't supported. Here's a screenshot:

image

You can see that not only are the lines of the string not highlighted correctly, but anything immediately following the string is incorrectly highlighted as well (in the second example the ;, and in the third example the ; and |> String.uppercase)

@ghost
Copy link
Author

ghost commented Nov 16, 2016

@jmmk thanks for reporting this. I've fixed the bug in the string highlighting and pushed a new version to the marketplace.

@jmmk
Copy link

jmmk commented Nov 17, 2016

@freebroccolo looks great, thanks!

@ghost ghost closed this as completed May 26, 2017
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant