Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up to date reason npm package #2456

Closed
baransu opened this issue Oct 2, 2019 · 8 comments
Closed

Up to date reason npm package #2456

baransu opened this issue Oct 2, 2019 · 8 comments

Comments

@baransu
Copy link

baransu commented Oct 2, 2019

The latest npm reason package version is 3.3.4 which is over a years old. We want to use it for reformatting between Reason and OCaml syntax and would be great to have access to up to date refmt version. Is there any reason why the package is not updated with every new release?

@ryyppy
Copy link
Contributor

ryyppy commented Nov 21, 2019

Now that I understand the vendoring process I can give more context:
The bspack.exe has been removed from recent bs-platform releases, which now blocks Reason's bspacks scripts to create a single refmtJS.ml bundle and run a build for refmt.js.

This apparently happened around 1 year ago I assume.

@thangngoc89
Copy link
Contributor

@ryyppy this isn't true. You don't need bspack to produce refmt.js . Probably just lacks of man-power

@ryyppy
Copy link
Contributor

ryyppy commented Nov 29, 2019

This is either solved by merging #2495 (opam based), or finishing work in #2153 (esy based)

@jchavarri
Copy link
Contributor

@thangngoc89 You mean refmt.js could be produced using a regular dune + jsoo setup? How would bucklescript compilation work? (side note: I always thought bspack was created originally because BS was a fork of OCaml and so could not be compiled with regular build tooling, but maybe that assumption is false and that's why I'm confused).

cc @ulrikstrid as we've been discussing about bspack stuff lately :)

@thangngoc89
Copy link
Contributor

@jchavarri refmt.js has been always produced by jsoo. Adding bspack into that is just noisy and more complexities for no reasons at all. bspack is for vendoring to bucklescript only

@jchavarri
Copy link
Contributor

You mean refmt.js could be produced using a regular dune + jsoo setup?

So the answer to that is yes?

@thangngoc89
Copy link
Contributor

Yes. refmt.js SHOULD be produce by a regular dune + jsoo setup

@anmonteiro
Copy link
Member

We don’t release to NPM anymore

@anmonteiro anmonteiro closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants